[L] Change in openvpn[master]: Remove instances of constParameterPointer cppcheck warnings

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1663?usp=email )

Change subject: Remove instances of constParameterPointer cppcheck warnings
......................................................................


Patch Set 17:

(3 comments)

File src/openvpn/mss.c:

http://gerrit.openvpn.net/c/openvpn/+/1663/comment/9baf0266_4a84e46c?usp=email :
PS17, Line 150:     struct openvpn_tcphdr *tc = (struct openvpn_tcphdr *)BPTR(buf);
For this function and a few others doing this sort of thing to the parameter it might not be ideal to constify the argument, because now we're pretending it's const when we're casting and writing to it inside the function.


File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/1663/comment/4907d4e9_173ee7aa?usp=email :
PS17, Line 3253: read_tun(struct tuntap *tt, uint8_t *buf, int len)
Shouldn't this (and the function above) have been constified as well? Do we no longer build for AIX? If not, should we just remove all the AIX code?


http://gerrit.openvpn.net/c/openvpn/+/1663/comment/1c2639ef_8a51a659?usp=email :
PS17, Line 6310: read_tun(struct tuntap *tt, uint8_t *buf, int len)
Here too, this function and the one above have not been constified.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1663?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I56248cf6d199c2da770774b8fd1e5daf2b116f58
Gerrit-Change-Number: 1663
Gerrit-PatchSet: 17
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Sun, 30 Aug 2026 19:01:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel