[S] Change in openvpn[master]: networking_sitnl: validate netlink replies against the request

Attention is currently required from: ordex, plaisthos.

ralf_lici has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1782?usp=email )

Change subject: networking_sitnl: validate netlink replies against the request
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1: 
The change looks good to me.

Just a minor nit: it would be useful to add a comment in sitnl_bind explaining why we copy nl_pid from the result after bind (that is, we let the kernel pick a unique pid for the socket). But I wouldn't block on this.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1782?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7
Gerrit-Change-Number: 1782
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: ralf_lici <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Tue, 01 Sep 2026 07:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel