[L] Change in openvpn[master]: Check for null-bytes in certificate subjects

Attention is currently required from: MaxF, plaisthos.

cron2 has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1898?usp=email )

Change subject: Check for null-bytes in certificate subjects
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
building the unit tests with -Werror fails, at least on the Ubuntus

```
o/build/ubuntu-2404-mingw/build/tests/unit_tests/openvpn/test_ssl.c: In function ???ssl_test_escape_rfc_2253_chars_in_subject???:
o/build/ubuntu-2404-mingw/build/tests/unit_tests/openvpn/test_ssl.c:1020:17: error: unused variable ???expected_subject_mbedtls??? [-Werror=unused-variable]
o 1020 |     const char *expected_subject_mbedtls = "CN=name\\, O\\=InjectedOrg, O=RealOrg";
o      |                 ^~~~~~~~~~~~~~~~~~~~~~~~
o/build/ubuntu-2404-mingw/build/tests/unit_tests/openvpn/test_ssl.c:1019:17: error: unused variable ???expected_subject_openssl??? [-Werror=unused-variable]
o 1019 |     const char *expected_subject_openssl = "CN=name\\, O=InjectedOrg, O=RealOrg";

```



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1898?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic334518048d6ca57a504257e210467f9c451d268
Gerrit-Change-Number: 1898
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: syzzer <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: MaxF <[email protected]>
Gerrit-Comment-Date: Sun, 06 Sep 2026 08:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel