Re: R: PPTPD on Fedora 17

i see this too with CVS HEAD and 1.3.4 on Fedora 17 on ARM.

strace shows pptpctrl is given arguments

["/usr/local/sbin/pptpctrl                                ", "0", "0",
"1", "/etc/ppp/options.pptpd", "0", "1", "192.168.0.1", "1",
"192.168.0.234", "256", "/usr/sbin/pppd", "1"]

but pppd is given arguments

["/usr/sbin/pppd", "local", "file", "/etc/ppp/options.pptpd",
"115200",
"\377\377\377\177\376\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377",
"ipparam", "10.0.0.2", "plugin", "/usr/lib/pptpd/pptpd-logwtmp.so",
"pptpd-original-ip", "10.0.0.2"]

the corrupted argument is generated by this code:

	if (*pppaddrs[0] || *pppaddrs[1]) {
		char pppInterfaceIPs[33];
		sprintf(pppInterfaceIPs, "%s:%s", pppaddrs[0], pppaddrs[1]);
		pppd_argv[an++] = pppInterfaceIPs;
	}

so my guess is that the variables have an incorrect value at the time.

i don't yet know why, but i suspect compiler changes combined with an
undiscovered bug in pptpd sources.

i suggest you look for srpm for fedora 16 and see if any changes were
made to fix this.

if you fix it, please let us know here so we can patch it.

-- 
James Cameron
http://quozl.linux.org.au/

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/