Re: [PATCH] Fix "Binary trash when launching ppp"

On Wed, Feb 6, 2013 at 6:42 PM, Christoph Biedl
<[email protected]> wrote:
> Description: Fix "Binary trash when launching ppp"

What does  "Binary trash when launching ppp" mean, and how does this fix it?

> Author: "[email protected]" <[email protected]>
> Bug-Debian: http://bugs.debian.org/693196
>
> --- a/pptpctrl.c
> +++ b/pptpctrl.c
> @@ -660,6 +660,7 @@
>         char *pppd_argv[16];
>         int an = 0;
>         sigset_t sigs;
> +       char pppInterfaceIPs[33];
>
>         pppd_argv[an++] = ppp_binary;
>
> @@ -760,7 +761,6 @@
>         }
>
>         if (*pppaddrs[0] || *pppaddrs[1]) {
> -               char pppInterfaceIPs[33];
>                 sprintf(pppInterfaceIPs, "%s:%s", pppaddrs[0], pppaddrs[1]);
>                 pppd_argv[an++] = pppInterfaceIPs;
>         }
>
>
> ------------------------------------------------------------------------------
> Free Next-Gen Firewall Hardware Offer
> Buy your Sophos next-gen firewall before the end March 2013
> and get the hardware for free! Learn more.
> http://p.sf.net/sfu/sophos-d2d-feb
> _______________________________________________
> Poptop-server mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/poptop-server

-- 
This e-mail (including any attachments) is for the sole use of the intended 
recipient(s) and may contain information that is confidential and/or 
protected by legal privilege. Any unauthorized review, use, copy, 
disclosure or distribution of this e-mail is strictly prohibited. If you 
are not the intended recipient, please notify Mitel immediately and destroy 
all copies of this e-mail.  Mitel does not accept any liability for breach 
of security, error or virus that may result from the transmission of this 
message.

------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb