Re: [PATCHES] More warning cleanup / minor fixes
James Cameron <[email protected]> Wed, 23 Oct 2013 15:51:10 +1100
| Newsgroups | gmane.network.poptop |
|---|---|
| Organization | Netrek Vanilla Server Dictator |
| Message-ID | <[email protected]> |
On Wed, Oct 23, 2013 at 01:56:46PM +1100, James Cameron wrote: > On Tue, Oct 22, 2013 at 10:46:18PM -0400, Charlie Brady wrote: > > On Tue, Oct 22, 2013 at 5:38 PM, James Cameron <[email protected]> wrote: > > > > > > Reviewing now. Pondering switching from tabs to spaces for indents; > > > what is your view on this? > > > > I think using spaces is preferable to tabs. But please, please, > > please, keep whitespace changes separate from any other code > > changes. > > Thanks, I agree, on both points. Looking for other opinions too. Pushed a tabs to spaces patch. -- James Cameron http://quozl.linux.org.au/ ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk