Re: buffer overflow detected in bcrelay

On Sun, Oct 26, 2014 at 09:16:44PM +0100, Christoph Biedl wrote:
> James Cameron wrote...
> 
> > Thanks for the review.  I've made a new commit.
> > 
> > http://sourceforge.net/p/poptop/git/ci/eee8ad1
> 
> Looks safe. The behaviour to discard an element if it's too long is a
> bit surprising but does no harm.

Yes.

I nearly ripped out the packet logging.

The use case for packet logging is testing or diagnosing problems in
bcrelay.  An alternative is tcpdump and then decryption of the PPTP
stream, combined with tcpdump of the tunnel interfaces, activated from
ip-up scripts.

> So I cherry-picked that one and did another upload to Debian, it
> should be not too late for the upcoming "jessie" release.

Thanks.

-- 
James Cameron
http://quozl.linux.org.au/

------------------------------------------------------------------------------