Re: pptpctrl invocation

Christoph Biedl <[email protected]> Fri, 8 Jul 2016 00:51:31 +0200
Newsgroups gmane.network.poptop
Message-ID <[email protected]>
James Cameron wrote...

> My guess is padding that will be written to later by the forked
> process; what does it look like when running normally?  See inststr.c
> and my_setproctitle in compat.c.

That makes sense.

> If so, a comment patch would be welcome.

How about the following?

    Christoph

--- a/pptpmanager.c
+++ b/pptpmanager.c
@@ -483,7 +483,12 @@ static void connectCall(int clientSocket, int clientNumber)
          * speed and option file on the command line.
          */
 
+#ifdef HAVE_SETPROCTITLE
+        ctrl_argv[pptpctrl_argc++] = PPTP_CTRL_BIN;
+#else
+        /* Add some padding so the forked process can change the title */
         ctrl_argv[pptpctrl_argc++] = PPTP_CTRL_BIN "                                ";
+#endif
 
         /* Pass socket as stdin */
         if (clientSocket != 0) {

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape