[quagga-users 14557] apparent bug in vty.c

We had been using quagga-0.99.20 for more than a year with no problems.
We recently upgraded to quagga-1.1.0 and started having problems.  After 
running for a couple days we would start getting these errors, where the
last 6 characters were random.

  Can't open configuration file /home/quagga/etc/bgpd.conf.NeSTFp.
  Can't open configuration file /home/quagga/etc/bgpd.conf.KjXzid.
  ...

I'd restart quagga and it would run fine for a day or two and then the same
problem occurred.

I tried looking thru the mailing lists to see if this has been addressed, but
didn't find anything - but then I couldn't find a way to search for anything
in the quagga mailing lists other than manually thru each message.  :(
So, sorry if this has already been addressed.

I made the following change to lib/vty.c and quagga seems to be stable now.

$ diff -upwb vty.c vty.c.orig
--- vty.c       2016-12-01 09:54:04.179979758 -0500
+++ vty.c.orig  2016-10-18 09:03:52.000000000 -0400
@@ -2298,12 +2298,6 @@ vty_close (struct vty *vty)
   else
     vty_stdio_reset ();
 
-  /*  This section added by hinkel 12/1/16 to fix a problem where quagga has
-      too many open files.  I think the problem is that vty->wfd wasn't getting
-      closed here.  */
-  if (vty->wfd > 0)
-    close (vty->wfd);
-
   if (vty->buf)
     XFREE (MTYPE_VTY, vty->buf);


thx
greg hinkel
Oak Ridge National Laboratory