[quagga-users 14616] Re: Quagga 1.2.0 released

On 02/08/2017 04:51 PM, Paul Jakma wrote:

Hi list,

> Hi,
> 
> Quagga 1.2.0 has been released, available from the usual place:
> 
> https://download.savannah.gnu.org/releases/quagga/
> 
> This is a feature release, for testing or more adventurous users. More
> conservative users may wish to stay with an older release. This release
> contains:
> 
> * Next-Hop Resolution Protocol support from Timo Teräs * BGP session
> establishment reworked, for speed and reliability
> * BGP route-advertisement timer interval default lowered, to 3s for eBGP
> and 1s for iBGP.
> * BGP Connect retries made more aggressive, with lower retry timer and a
> slower-ramping backoff.

great to hear of all bug fixes and new features implemented. :)

I just wanted to let you know that building an RPM (recent CentOS 7
x86_64) fails in NHRPd:

make[2]: Leaving directory `/home/tis/rpmbuild/BUILD/quagga-1.2.0/ospf6d'
Making all in nhrpd
make[2]: Entering directory `/home/tis/rpmbuild/BUILD/quagga-1.2.0/nhrpd'
  CC       zbuf.o
  CC       znl.o
zbuf.c:10:0: warning: "_GNU_SOURCE" redefined [enabled by default]
 #define _GNU_SOURCE
 ^
<command-line>:0:0: note: this is the location of the previous definition
  CC       resolver.o
  CC       linux.o
  CC       netlink_arp.o
  CC       netlink_gre.o
  CC       vici.o
In file included from netlink_gre.c:15:0:
/usr/include/linux/ipv6.h:19:8: error: redefinition of 'struct in6_pktinfo'
 struct in6_pktinfo {
        ^
In file included from netlink_gre.c:10:0:
/usr/include/netinet/in.h:536:8: note: originally defined here
 struct in6_pktinfo
        ^
In file included from netlink_gre.c:15:0:
/usr/include/linux/ipv6.h:24:8: error: redefinition of 'struct ip6_mtuinfo'
 struct ip6_mtuinfo {
        ^
In file included from netlink_gre.c:10:0:
/usr/include/netinet/in.h:543:8: note: originally defined here
 struct ip6_mtuinfo
        ^
make[2]: *** [netlink_gre.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/home/tis/rpmbuild/BUILD/quagga-1.2.0/nhrpd'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/tis/rpmbuild/BUILD/quagga-1.2.0'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.EUzxPZ (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.EUzxPZ (%build)

Would it be feasible to introduce a "with-feature option" for this (in
the SPEC file)?

Best,

Timo