CVS: rdesktop secure.c, 1.70, 1.71 xkeymap.c, 1.101, 1.102

Update of /cvsroot/rdesktop/rdesktop
In directory sfp-cvsdas-4.v30.ch3.sourceforge.com:/tmp/cvs-serv28435

Modified Files:
	secure.c xkeymap.c 
Log Message:
fix two problems found by clang static analyzer

secure.c:  829: Dereference of null pointer
xkeymap.c: 799: Pass-by-value argument in function call is undefined

both seem to be noncritical, as sec_recv is never called with a null
pointer and ensure_remote_modifiers only accesses initialized fields


Index: secure.c
===================================================================
RCS file: /cvsroot/rdesktop/rdesktop/secure.c,v
retrieving revision 1.70
retrieving revision 1.71
diff -C2 -d -r1.70 -r1.71
*** secure.c	11 Jul 2008 03:51:23 -0000	1.70
--- secure.c	7 Apr 2010 11:22:13 -0000	1.71
***************
*** 827,831 ****
  		{
  			channel_process(s, channel);
! 			*rdpver = 0xff;
  			return s;
  		}
--- 827,832 ----
  		{
  			channel_process(s, channel);
! 			if (rdpver != NULL)
! 				*rdpver = 0xff;
  			return s;
  		}

Index: xkeymap.c
===================================================================
RCS file: /cvsroot/rdesktop/rdesktop/xkeymap.c,v
retrieving revision 1.101
retrieving revision 1.102
diff -C2 -d -r1.101 -r1.102
*** xkeymap.c	11 Jul 2008 03:51:23 -0000	1.101
--- xkeymap.c	7 Apr 2010 11:22:13 -0000	1.102
***************
*** 790,794 ****
  restore_remote_modifiers(uint32 ev_time, uint8 scancode)
  {
! 	key_translation dummy;
  
  	if (is_modifier(scancode))
--- 790,794 ----
  restore_remote_modifiers(uint32 ev_time, uint8 scancode)
  {
! 	key_translation dummy = { };
  
  	if (is_modifier(scancode))


------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev