CVS: rdesktop disk.c,1.21,1.22

Update of /cvsroot/rdesktop/rdesktop
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8933

Modified Files:
	disk.c 
Log Message:
Notes on FileDispositionInformation. Closing before unlinking

Index: disk.c
===================================================================
RCS file: /cvsroot/rdesktop/rdesktop/disk.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -C2 -d -r1.21 -r1.22
*** disk.c	15 Apr 2004 20:53:32 -0000	1.21
--- disk.c	16 Apr 2004 11:37:24 -0000	1.22
***************
*** 609,617 ****
  
  		case FileDispositionInformation:
! 
! 			//unimpl("IRP Set File Information class: FileDispositionInformation\n");
  
  			//in_uint32_le(in, delete_on_close);
! 			// disk_close(handle);
  			if ((pfinfo->flags_and_attributes & FILE_DIRECTORY_FILE))	// remove a directory
  			{
--- 609,631 ----
  
  		case FileDispositionInformation:
! 			/* As far as I understand it, the correct
! 			   thing to do here is to *schedule* a delete,
! 			   so it will be deleted when the file is
! 			   closed. Subsequent
! 			   FileDispositionInformation requests with
! 			   DeleteFile set to FALSE should unschedule
! 			   the delete. See
! 			   http://www.osronline.com/article.cfm?article=245. Currently,
! 			   we are deleting the file immediately. I
! 			   guess this is a FIXME. */
  
  			//in_uint32_le(in, delete_on_close);
! 
! 			/* Make sure we close the file before
! 			   unlinking it. Not doing so would trigger
! 			   silly-delete if using NFS, which might fail
! 			   on FAT floppies, for example. */
! 			disk_close(handle);
! 
  			if ((pfinfo->flags_and_attributes & FILE_DIRECTORY_FILE))	// remove a directory
  			{



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click