[ rdesktop-Patches-2847294 ] Fix for segfaults in disk_query_information

Patches item #2847294, was opened at 2009-08-30 16:26
Message generated for change (Tracker Item Submitted) made by thermal
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=2847294&group_id=24366

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Maciek Grela (thermal)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for segfaults in disk_query_information

Initial Comment:
The return value of strrchr in disk_query_information is not properly tested causing segfaults like these:

GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) run  -u quux -p z0ran -g 1024x768 -x m -z -a 8 -T GUIS -r disk:floppy=. 10.4.10.20 
Starting program: /usr/bin/rdesktop -u quux -p z0ran -g 1024x768 -x m -z -a 8 -T GUIS -r disk:floppy=. 10.4.10.20
Autoselected keyboard map pl

Program received signal SIGSEGV, Segmentation fault.
0x0000000000425673 in disk_query_information (handle=<value optimized out>, info_class=4, out=0x7fff2c7fd2d0) at disk.c:643
643     disk.c: No such file or directory.
        in disk.c
        (gdb) bt
        #0  0x0000000000425673 in disk_query_information (handle=<value optimized out>, info_class=4, out=0x7fff2c7fd2d0) at disk.c:643
        #1  0x0000000000423052 in rdpdr_process_irp (s=0x6b2fc0) at rdpdr.c:570
        #2  0x000000000042361f in rdpdr_process (s=0x7d3ef0) at rdpdr.c:799
        #3  0x00000000004174ed in sec_recv (rdpver=0x7fff2c7fd41f "\003\030�\177,�\177") at secure.c:828
        #4  0x0000000000418bb0 in rdp_recv (type=0x7fff2c7fd47f "") at rdp.c:89
        #5  0x0000000000419a35 in rdp_loop (deactivated=0x7fff2c7fd81c, ext_disc_reason=0x7fff2c7fd818) at rdp.c:1411
        #6  0x000000000041a4f4 in rdp_main_loop (deactivated=0x7fff2c7fd81c, ext_disc_reason=0x7fff2c7fd818) at rdp.c:1396
        #7  0x0000000000407463 in main (argc=<value optimized out>, argv=<value optimized out>) at rdesktop.c:954
        (gdb) 


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=2847294&group_id=24366

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
rdesktop-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rdesktop-devel