[ rdesktop-Patches-2917988 ] Full color mouse cursors

Patches item #2917988, was opened at 2009-12-20 14:32
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=2917988&group_id=24366

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Michael Gilbert (floppym)
Assigned to: Nobody/Anonymous (nobody)
Summary: Full color mouse cursors

Initial Comment:
Adding support for full color mouse cursors based on work done in artifact 2884937.

This patch requires libXcursor, which ships with recent versons of XFree86 and Xorg.  In this context, the Xcursor library basically acts as a wrapper around around libXrender, falling back to Xlib calls if the RENDER extension is not available.

I think configure.ac should probably be changed to reflect the new dependency, but I have never done any work with autoconf.

Some of the code still feels "dirty" to me, especially the handling of the andmask bitfield.  I also have no idea if this works for bpp values other than 1 and 32 since I can't figure out how to get the server to send anything else.

I will happily take any suggestions for cleaning things up.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2010-05-28 18:47

Message:
root@template1:/.backup/rdesktop/rdesktop-1.6.0# patch -p1 < xcursor.patch
patching file Makefile.in
Hunk #1 succeeded at 39 (offset 4 lines).
patching file xwin.c
Hunk #2 FAILED at 2778.
Hunk #3 FAILED at 2830.
2 out of 3 hunks FAILED -- saving rejects to file xwin.c.rej


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=2917988&group_id=24366

------------------------------------------------------------------------------