[ rdesktop-Patches-1556893 ] Installation fix for Cygwin

Patches item #1556893, was opened at 2006-09-12 07:31
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1556893&group_id=24366

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ed Avis (epaepa)
Assigned to: Nobody/Anonymous (nobody)
Summary: Installation fix for Cygwin

Initial Comment:
Doing 'make install' fails on Cygwin when it tries to
strip the installed rdesktop binary - because on Cygwin
the filename is rdesktop.exe.  To fix this, get
install(1) to do the stripping itself with the -s flag:

--- Makefile.in~	2005-05-04 21:32:16.000000000 +0100
+++ Makefile.in	2006-09-12 08:24:01.050540900 +0100
@@ -55,8 +55,7 @@
 .PHONY: installbin
 installbin: rdesktop
 	mkdir -p $(DESTDIR)$(bindir)
-	$(INSTALL) rdesktop $(DESTDIR)$(bindir)
-	strip $(DESTDIR)$(bindir)/rdesktop
+	$(INSTALL) -s rdesktop $(DESTDIR)$(bindir)
 	chmod 755 $(DESTDIR)$(bindir)/rdesktop
 
 .PHONY: installman


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2010-08-21 03:36

Message:
MyutNE  <a href="http://wljfmejdwhkj.com/">wljfmejdwhkj</a>,
[url=http://wdenivvedugg.com/]wdenivvedugg[/url],
[link=http://qpuzwuoezfma.com/]qpuzwuoezfma[/link],
http://qihgcvyrpqnu.com/

----------------------------------------------------------------------

Comment By: Adrian Davey (adavey)
Date: 2006-09-12 09:24

Message:
Logged In: YES 
user_id=152874

can you test the current CVS version first as this is
against 1.4.1 not CVS HEAD.

'install -s' is not guaranteed to work with all cross
compiled environments.

perhaps a strip of an rdesktop binary variable would be
better, allowing for if strip exists then use it against a
variable such as:
$(STRIP) $(DESTDIR)$(bindir)/$(RDESKTOP_BINARY)

this will then use the strip found in autofoo and still work
if no strip is found.  also allows for a version'ed binary
too rdesktop-1.5 etc.




----------------------------------------------------------------------

Comment By: Ilya Konstantinov (ikonst)
Date: 2006-09-12 09:07

Message:
Logged In: YES 
user_id=335423

Looks legit. Could someone with CVS permissions check this in?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1556893&group_id=24366

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev