Re: Could we add this patch?

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--789238529-1895284974-1352971592=:11553
Content-Type: TEXT/PLAIN; CHARSET=UTF-8; format=flowed
Content-ID: <[email protected]>
Content-Transfer-Encoding: quoted-printable


Hi. My goal is to eliminate the crazy daylight saving time. In Europe, we=
=20
have http://timeinitiative.eu/, which is now gaining momentum. Don't you=20
have anything similar in the US? :-))

Anyway, wrt the actual patch: I'm positive to fixing this. It's a bit=20
unfortunate though that we need so much code (the patch is almost 400=20
lines) just to fix such a small problem. But perhap's there's no better=20
way. A few comments:

* Having a special --with-debug-time configure flag is a bit overkill if=20
you ask me. The debug macro can be internal to the implementation file.

* Since some code is borrowed from Wine, we need to take care when it=20
comes to the licensing. rdesktop is GPLv3 only. The Wine code was LGPL 2.=
1=20
or later. According to http://gplv3.fsf.org/dd3-faq, this is "OK if you=20
convert to GPLv3". So the license header must be changed.

If this is fixed, I think we can apply the patch.

Rgds,
Peter


On Thu, 15 Nov 2012, Lance Wang wrote:

> Hi
>
> Could we add the patch in the next release?
>
> http://sourceforge.net/tracker/?func=3Ddetail&aid=3D2168898&group_id=3D=
24366&atid=3D381349
>
> It is very useful.
>
> Or
>
> Anybody tell me why it is can not be accepted?
>
> Thanks.
>
> --=20
> :
> Lance Wang
>
> U+738B U+4F36 U+5353
>
> -----------------------------------------------------------------------=
-------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware=
,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> rdesktop-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/rdesktop-devel
>


---
Peter =C3=85strand		ThinLinc Chief Developer
Cendio AB		http://cendio.com
Teknikringen 8		http://twitter.com/ThinLinc
583 30 Link=C3=B6ping	http://facebook.com/ThinLinc
Phone: +46-13-214600	http://plus.google.com/112509906846170010689
--789238529-1895284974-1352971592=:11553
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
--789238529-1895284974-1352971592=:11553
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
rdesktop-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rdesktop-devel

--789238529-1895284974-1352971592=:11553--