Re: Problem with key '2' (kp_downarrow) on numpad

> Thanks Jay! That solved the problem.

Great.
I think this may be something that we should fix in rdesktop.
The default behavior for rdesktop is to always leave the Num Lock off
and only toggle it when needed.  I think this is for some flexibility
with other keymaps.
The problem is rdesktop sends for example if I press '2' on the keypad
Num lock on
2 key down
Num lock off
2 key up.
As you can see, at the point of the '2 key up' its really an 'arrow
down key up' at that point cause the num lock is off.  It should send
Num lock on
2 key down
2 key up.
Num lock off
I've been meaning to ask Peter about this.  I just tested, it seems to
do this with the latest cvs version and I think its done this for a
very long time.
Peter, what do you think?

This little patch seems to fix it for me.

diff -u -r1.97 xkeymap.c
--- xkeymap.c   8 Feb 2007 12:56:37 -0000       1.97
+++ xkeymap.c   16 Mar 2007 03:57:51 -0000
@@ -697,11 +697,11 @@
                        save_remote_modifiers(tr.scancode);
                        ensure_remote_modifiers(ev_time, tr);
                        rdp_send_scancode(ev_time, RDP_KEYPRESS, tr.scancode);
-                       restore_remote_modifiers(ev_time, tr.scancode);
                }
                else
                {
                        rdp_send_scancode(ev_time, RDP_KEYRELEASE, tr.scancode);
+                       restore_remote_modifiers(ev_time, tr.scancode);
                }
                return;
        }


Jay

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV