Build failure nsclick

Sascha Alexander Jopen <[email protected]>
Newsgroups gmane.network.routing.click
Message-ID <[email protected]>
Hey,

Some recent changes lead to build failures when compiling with
--enable-nsclick.

One reason is simply a missing address operator in timestamp.hh, fixed
with the attached patch.

The second problem is about the TIMESTAMP_WARPABLE definition in
include/click/timestamp.hh around line 116 and the usage of some warp
functions in include/click/timer.hh araound line 306.
TIMESTAMP_WARPABLE is defined if !CLICK_NS but the function warp_jumping
is used by only checking CLICK_USERLEVEL

Either TIMESTAMP_WARPABLE should be used witch CLICK_NS, or the timer
should check against TIMESTAMP_WARPABLE instead of CLICK_USERLEVEL.

Because i don't know what this time warping actually does, its up to you
to find the correct solution :-) Maybe other code is affected, too.

Regards,
Sascha Jopen

_______________________________________________
click mailing list
[email protected]
https://amsterdam.lcs.mit.edu/mailman/listinfo/click
click-timestamp-ns.patch (text/x-patch, 468 B)
diff -r -u click-20110906/include/click/timestamp.hh click-20110906-patched/include/click/timestamp.hh
--- click-20110906/include/click/timestamp.hh	2011-09-06 04:00:30.000000000 +0200
+++ click-20110906-patched/include/click/timestamp.hh	2011-09-06 10:17:02.000000000 +0200
@@ -810,7 +810,7 @@
 
 #elif CLICK_NS
     TIMESTAMP_DECLARE_TVP;
-    simclick_gettimeofday(tvp);
+    simclick_gettimeofday(&tvp);
     TIMESTAMP_RESOLVE_TVP;
 
 #elif HAVE_USE_CLOCK_GETTIME
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.