linux todevice lock problem

Hi,

[ 594.664181] NETDEV WATCHDOG: eth0: transmit timed out

Sometimes I got this error messages.
I found commit related this problem.

http://read.cs.ucla.edu/gitweb?p=click;a=commit;h=01c8f4e084036338e83a6bff7a8e74dc49caa014

And i think this is problem macro.

# define click_netif_needs_lock(dev)           (((dev)->features &
NETIF_F_LLTX) != 0)

According to this article http://lwn.net/Articles/101215/
lock is needed when dev->features dosen't have NETIF_F_LLTX
So, I think need change like this

--------------------------
--- a/elements/linuxmodule/todevice.cc
+++ b/elements/linuxmodule/todevice.cc
@@ -258,7 +258,7 @@ ToDevice::cleanup(CleanupStage stage)
 #endif

 #ifdef NETIF_F_LLTX
-# define click_netif_needs_lock(dev)           (((dev)->features &
NETIF_F_LLTX) != 0)
+# define click_netif_needs_lock(dev)           (((dev)->features &
NETIF_F_LLTX) == 0)
 #else
 # define click_netif_needs_lock(dev)           1
 #endif
---------------------------

Thanks,

-- 
Brian Kim, 김계연
_______________________________________________
click mailing list
[email protected]
https://amsterdam.lcs.mit.edu/mailman/listinfo/click