Re: Release 2.1

Hey Eddie,

ohoh, i'm really sorry. Obviously i missed to send a notification to you
after committing the random number patch to ns-3-dev. It was added in
changeset 9230 revision 01be79275088 to the ns-3-dev repository in February.

Drawing random numbers is now done from independed random number streams
for each node in the simulation, as opposed to a drawing from a single
stream for all nodes as implemented by the previous patch.

However, i found another bug on the click side for the click defines
patch for ns3. I still have no github fork of the click repository, so
please use the attached patch with the fix.

>From my side there is no objection to releasing 2.1.

Regards,
Sascha


On 25.04.2013 15:54, Eddie Kohler wrote:
> Hey Sascha,
> 
> I was waiting for your response about the random number support patch
> but didn't hear from you. Do you have outstanding patches to Click
> that you would like to get integrated?
> 
> Eddie
> 
> 
> On Fri, Jan 18, 2013 at 4:17 AM, Sascha Alexander Jopen
> <[email protected]> wrote:
>> Hi Eddie,
>>
>> i still have outstanding patches to click. At least the random number
>> support with ns3 patch, see
>> http://www.mail-archive.com/[email protected]/msg05860.html.
>>
>> However, i would like to review this patch, because ns3 random number
>> handling has slightly changed meanwhile. This should only affect the ns3
>> part of the patch. This should be ready by monday.
>>
>> Sascha
>>
>> On 17.01.2013 21:00, Eddie Kohler wrote:
>>> Hi all,
>>>
>>> I plan to release Click 2.1 shortly. Let me know if there's something
>>> outstanding from the mailing list that I should be sure to consider
>>> first.
>>>
>>> Eddie
>>> _______________________________________________
>>> click mailing list
>>> [email protected]
>>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>>>
>>
>>
>> --
>> Dipl.-Inform. Sascha Jopen
>>
>> University of Bonn                     Tel.:   +49-228-73-54219
>> Institute of Computer Science 4        Fax:    +49-228-73-4571
>> Friedrich-Ebert-Allee 144              E-mail: [email protected]
>> D-53113 Bonn, Germany
>> _______________________________________________
>> click mailing list
>> [email protected]
>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click


-- 
Dipl.-Inform. Sascha Jopen

University of Bonn                     Tel.:   +49-228-73-54219
Institute of Computer Science 4        Fax:    +49-228-73-4571
Friedrich-Ebert-Allee 144              E-mail: [email protected]
D-53113 Bonn, Germany

_______________________________________________
click mailing list
[email protected]
https://amsterdam.lcs.mit.edu/mailman/listinfo/click

diff --git a/ns/nsclick.cc b/ns/nsclick.cc
index 4cfd0ae..34461ac 100644
--- a/ns/nsclick.cc
+++ b/ns/nsclick.cc
@@ -135,7 +135,7 @@ int simclick_click_create(simclick_node_t *simnode, const char* router_file) {
         while (defines_offset < defines_size) {
             char *key = defines + defines_offset;
             char *value = key + strlen(key) + 1;
-            defines_offset += (size_t) (value + strlen(value) + 1 - defines);
+            defines_offset = (size_t) (value + strlen(value) + 1 - defines);
             if (!click_lexer()->global_scope().define(key, value, false)) {
                 errh->error("parameter %s multiply defined", key);
             }