Re: PATCH: add --no-symlink-perms option for ignoring symlink permissions on transfer
Roland Kletzing via rsync <[email protected]> Mon, 1 Jun 2026 12:43:33 +0200
| Newsgroups | gmane.network.rsync.general |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format.
--===============3444427500516130262==
Content-Type: multipart/alternative;
boundary="------------rSLk3qREL4m2ckpkw044y4NB"
This is a multi-part message in MIME format.
--------------rSLk3qREL4m2ckpkw044y4NB
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
i guess my patch was too short sightet, as i think this only works when=20
pushing from linux to macos
when pushing from macos to linux, won't we also need to transfer the=20
option to the remote ?
https://github.com/RsyncProject/rsync/commit/224afb815e2dc1543b53fdb922286=
32298c0ca24
unfortunately, i cannot yet test this, i need to setup build-env on=20
macos first , when i have free
system around wherei can do that
regards
Roland
Am 01.06.26 um 11:42 schrieb RolandK via rsync:
> Hi,
>
>> Am 01.06.26 um 00:24 schrieb Andrew Tridgell:
>> Hi Roland,
>> This sounds like it is worth fixing. I have a mac mini here I could
>> test against.
> nice, thanks for positive feedback.
>> A PR would be welcome, but please see if you can come up with a
>> testsuite (may be a bit tricky as this is an inter-platform issue, we
>> may need to spin up a linux VM within the macos CI runner).
> i don't yet have a clue, how automated testing in rsync works. think i
> will need a while to get into this.
>> I have no problem with you using AI to develop patches. All changes
>> will also be reviewed by humans. I've using claude a lot, but I also
>> cross-check all changes with codex and check things by hand as well. I
>> do also require test suites for all new features (and I've been
>> greatly expanding the test suites for existing features).
> sounds like a good approach !
>> On your patch, I'd prefer --omit-link-perms, similar to
>> --omit-link-times.
> ok, sounds reasonable. i will commit a fix for this.
>> Maybe we should make this the default for macos ->
>> linux transfers?
>> Cheers, Tridge
> ok, but how can this be done ?
> regards
> Roland
>
--------------rSLk3qREL4m2ckpkw044y4NB
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html>
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF-=
8">
</head>
<body>
<p>i guess my patch was too short sightet, as i think this only
works when pushing from linux to macos<br>
<br>
when pushing from macos to linux, won't we also need to transfer
the option to the remote ?<br>
<br>
<a class=3D"moz-txt-link-freetext" href=3D"https://github.com/RsyncProject=
/rsync/commit/224afb815e2dc1543b53fdb92228632298c0ca24">https://github.com=
/RsyncProject/rsync/commit/224afb815e2dc1543b53fdb92228632298c0ca24</a><br=
>
<br>
unfortunately, i cannot yet test this, i need to setup build-env
on macos first , when i have free=C2=A0<br>
system around wherei can do that<br>
<br>
regards<br>
Roland=C2=A0<br>
<br>
</p>
<p><br>
<br>
<br>
<br>
</p>
<div class=3D"moz-cite-prefix">Am 01.06.26 um 11:42 schrieb RolandK
via rsync:<br>
</div>
<blockquote type=3D"cite"
cite=3D"mid:[email protected]">
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUT=
F-8">
<pre>Hi,
</pre>
<blockquote type=3D"cite"
cite=3D"mid:[email protected]=
.com">
<pre class=3D"moz-cite-prefix">Am 01.06.26 um 00:24 schrieb Andrew=
Tridgell:
Hi Roland,
This sounds like it is worth fixing. I have a mac mini here I could
test against.</pre>
</blockquote>
<pre wrap=3D"" class=3D"moz-quote-pre">nice, thanks for positive fee=
dback.</pre>
<blockquote type=3D"cite"
cite=3D"mid:[email protected]=
.com">
<pre wrap=3D"" class=3D"moz-quote-pre">A PR would be welcome, but =
please see if you can come up with a
testsuite (may be a bit tricky as this is an inter-platform issue, we
may need to spin up a linux VM within the macos CI runner).</pre>
</blockquote>
<pre wrap=3D"" class=3D"moz-quote-pre">i don't yet have a clue, how =
automated testing in rsync works. think i=20
will need a while to get into this.</pre>
<blockquote type=3D"cite"
cite=3D"mid:[email protected]=
.com">
<pre wrap=3D"" class=3D"moz-quote-pre">I have no problem with you =
using AI to develop patches. All changes
will also be reviewed by humans. I've using claude a lot, but I also
cross-check all changes with codex and check things by hand as well. I
do also require test suites for all new features (and I've been
greatly expanding the test suites for existing features).</pre>
</blockquote>
<pre>sounds like a good approach !</pre>
<blockquote type=3D"cite"
cite=3D"mid:[email protected]=
.com">
<pre wrap=3D"" class=3D"moz-quote-pre">On your patch, I'd prefer -=
-omit-link-perms, similar to
=2D-omit-link-times.=20
</pre>
</blockquote>
<pre wrap=3D"" class=3D"moz-quote-pre" style=3D"white-space: pre-wra=
p;">ok, sounds reasonable. i will commit a fix for this.</pre>
<blockquote type=3D"cite"
cite=3D"mid:[email protected]=
.com">
<pre wrap=3D"" class=3D"moz-quote-pre">Maybe we should make this t=
he default for macos ->
linux transfers?
Cheers, Tridge</pre>
</blockquote>
<pre><pre wrap=3D"" class=3D"moz-quote-pre">ok, but how can this be =
done ?</pre>regards=C2=A0
Roland</pre>
<br>
<fieldset class=3D"moz-mime-attachment-header"></fieldset>
</blockquote>
</body>
</html>
--------------rSLk3qREL4m2ckpkw044y4NB--
--===============3444427500516130262==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
--===============3444427500516130262==--