autobuild[sn-devel-104]: intermittent test failure detected

[email protected] (autobuild)
Newsgroups gmane.network.samba.cvs
Message-ID <[email protected]>
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-01-0407/flakey.log

The samba build logs are available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-01-0407/samba.stderr
   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-01-0407/samba.stdout
  
The top commit at the time of the failure was:

commit c98bdf24941ad95250d79eeed26c57d600cedc7b
Author: Douglas Bagnall <[email protected]>
Date:   Wed Nov 30 14:56:16 2016 +1300

    smbd/service_stream: connection processing flag is not really bool
    
    The warning is:
    
    ../source4/smbd/service_stream.c: In function ‘stream_io_handler’:
    ../source4/smbd/service_stream.c:94:18: warning: increment of a boolean expression [-Wbool-operation]
      conn->processing++;
                        ^~
    ../source4/smbd/service_stream.c:100:18: warning: decrement of a boolean expression [-Wbool-operation]
      conn->processing--;
                        ^~
    
    while the code in question looks like:
    
    	conn->processing++;
    	if (flags & TEVENT_FD_WRITE) {
    		conn->ops->send_handler(conn, flags);
    	} else if (flags & TEVENT_FD_READ) {
    		conn->ops->recv_handler(conn, flags);
    	}
    	conn->processing--;
    
    If this is never going to be nested, processing can be bool and the ++
    and -- can be true/false assignments. But it seems possible that these
    might be nested so it is better to go the other way.
    
    Signed-off-by: Douglas Bagnall <[email protected]>
    Reviewed-by: Ralph Boehme <[email protected]>
    
    Autobuild-User(master): Ralph Böhme <[email protected]>
    Autobuild-Date(master): Thu Dec  1 00:28:05 CET 2016 on sn-devel-144
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.