Re: [PATCH] smb: client: Compare MACs in constant time
Eric Biggers <[email protected]>
| Newsgroups | gmane.linux.kernel.cryptoapi,gmane.linux.kernel.cifs,gmane.network.samba.internals,gmane.linux.kernel.stable |
|---|---|
| Message-ID | <20260303050439.GB5238@sol> |
On Tue, Feb 17, 2026 at 08:27:02PM -0800, Eric Biggers wrote:
> To prevent timing attacks, MAC comparisons need to be constant-time.
> Replace the memcmp() with the correct function, crypto_memneq().
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: [email protected]
> Signed-off-by: Eric Biggers <[email protected]>
> ---
> fs/smb/client/smb1encrypt.c | 3 ++-
> fs/smb/client/smb2transport.c | 4 +++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
Any feedback on this? Just to clarify, this is intended to be taken
through the smb tree.
- Eric