Re: [PATCH] smb: client: Compare MACs in constant time
Paulo Alcantara <[email protected]>
| Newsgroups | gmane.linux.kernel.stable,gmane.linux.kernel.cifs,gmane.network.samba.internals,gmane.linux.kernel.cryptoapi |
|---|---|
| Message-ID | <[email protected]> |
Eric Biggers <[email protected]> writes: > To prevent timing attacks, MAC comparisons need to be constant-time. > Replace the memcmp() with the correct function, crypto_memneq(). > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: [email protected] > Signed-off-by: Eric Biggers <[email protected]> > --- > fs/smb/client/smb1encrypt.c | 3 ++- > fs/smb/client/smb2transport.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) Acked-by: Paulo Alcantara (Red Hat) <[email protected]>