Re: [PATCH v4] smb: client: fix state-consistency bugs in smb3_reconfigure() multichannel path
Henrique Carvalho <[email protected]> Wed, 29 Apr 2026 17:45:59 -0300
| Newsgroups | gmane.linux.kernel,gmane.linux.kernel.cifs,gmane.network.samba.internals |
|---|---|
| Message-ID | <mhc4fpsjriwsrrtsms3uhqueihguf7vztnwxbnj7tud52e6rq3@dkfi5w6zmdkh> |
Hi DaeMyung, Thank you for the update. This version is better than the previous one, but I think it still needs some work. First, `mchan_rc` appears to be vestigial in its current form, so I do not think it should stay. Second, I think remount/reconfigure should be all-or-nothing. If any part of the reconfigure attempt fails, we should not commit the rest of the changes, otherwise userspace gets an error without a clear view of what actually took effect. As written, I do not understand why `scale_busy` is handled specially while other failure paths are not. Lastly, please shorten the commit message. It would be better to follow the style of nearby CIFS commit logs. Thanks, Henrique