Re: [PATCH rdma-next v8] RDMA: Change capability fields in ib_device_attr from int to u32
Erni Sri Satya Vennela <[email protected]> Wed, 1 Jul 2026 23:03:43 -0700
| Newsgroups | gmane.linux.scsi.target.devel,gmane.linux.drivers.rdma,gmane.linux.kernel,gmane.linux.kernel.cifs,gmane.network.samba.internals,gmane.linux.nfs,gmane.linux.network |
|---|---|
| Message-ID | <akX/P/0TiSQ38YdS@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> |
On Fri, Jun 19, 2026 at 01:30:39PM -0700, Erni Sri Satya Vennela wrote: > The capability counter fields in struct ib_device_attr are declared > as signed int, but these values are inherently non-negative. Drivers > maintain their cached caps as u32 and assign them directly into these > int fields; if a cap exceeds INT_MAX the implicit narrowing yields a > negative value visible to the IB core. > > Change the signed int capability fields to u32 to match the > underlying nature of the data. Also update consumers across the IB > core, ULPs, NVMe-oF target, RDS, and NFS/RDMA so the new u32 values > are not forced back through signed int or u8 via min()/min_t() or > narrowing local variables. > > Suggested-by: Jason Gunthorpe <[email protected]> > Signed-off-by: Erni Sri Satya Vennela <[email protected]> > Acked-by: Stefan Metzmacher <[email protected]> # smbdirect Hi, Just a friendly follow-up on this patch. The Sashiko review mentioned a low-priority item, and I'd appreciate any guidance on whether the change is needed. https://sashiko.dev/#/patchset/20260619203107.606359-1-ernis%40linux.microsoft.com Thanks, Vennela