Re: Docs bug

On Fri, Dec 16, 2011 at 11:59 AM, Michal Bacik
<[email protected]> wrote:
> Docs: http://jcifs.samba.org/src/docs/api/jcifs/smb/SmbFile.html
>
> Line:
>   smb://[[[domain;]username[:password]@]server[:port]/[[share/[dir/]file]]]
> [?[param=value[param2=value2[...]]]
>
> In 2nd part, near ? char, there're 4 open braces '[', while only 3 closing
> braces ']'
>
> Probably one brace ] is missing at the end.

Hi Michal,

Actually, I think it would be better to just remove the [ just before
"param=" like:

  smb://[[[domain;]username[:password]@]server[:port]/[[share/[dir/]file]]][?param=value[param2=value2[...]]]

Even though technically you could have a question mark without any
query_string parameters I think it's clearer to go with fewer
brackets.

I have changed this in my local copy so eventually the fix will trickle down.

Thanks for the feedback,
Mike

-- 
Michael B Allen
Java Active Directory Integration
http://www.ioplex.com/