Re: silc-client segfault when using /quit or disconnect

Hi,

indeed:

http://www.silcnet.org/docs/changelog/SILC%20Client%201.1.6

mentions:

"Split out a patch from Skywing <[email protected]> to fix a
NULL pointer dereference when the client leaves a +k channel and the
local user had set a key for the channel."

Is there a specific patch/diff, so I can port the fix to the released
version packages?

Thanks a lot,

ccm.



On Thu, Nov 06, 2008 at 09:32:33AM -0600, Skywing wrote:
> I think that Pekka has integrated the necessary patch for this as of the latest release.  Copying him to be certain, however.
> 
> - S
> 
> -----Original Message-----
> From: silc-devel-bounces-cR8azDVoa3JZ/hxrHI3Fm9i2O/[email protected] [mailto:[email protected]] On Behalf Of Caspar Clemens Mierau
> Sent: Thursday, November 06, 2008 10:33 AM
> To: silc-devel-cR8azDVoa3JZ/hxrHI3Fm9i2O/[email protected]
> Subject: silc-client segfault when using /quit or disconnect
> 
> Hi there,
> 
> let me introduce a bug from the launchpad bug tracker to you:
> 
> https://bugs.launchpad.net/ubuntu/+source/silc-client/+bug/275989
> 
> It seems, that silc-client crashes when you are using "/key channel"
> protected channels and use /quit or get a disconnect. In order to reproduce it, try:
> 
> - start silc session
> - connect to a server
> - join a channel that has a "/key channel CHANNELNAME password PASSWORD"
>   set and set it
> - "/quit"
> 
> silc-client will crash with a hint on "silccipher.c:377" when having debug symbols installed. it will also crash, when you have a forced disconnect (due to connectivity).
> 
> You'll find a backtrace here:
> 
> http://launchpadlibrarian.net/18055254/silc-gdb.txt
> 
> I assume there needs to be a check like 
> 
> "if (!(channel->internal.send_key == NULL))" close to silccipher.c:377
> 
> this behaviour has been found on Ubuntu Hardy and Intrepid. Maybe a check against the newest release is necessary.
> 
> 
> I hope these information help investigating the bug. If you provide a patch, I'll send it to the Debian and Ubuntu project.
> 
> Best.

-- 
Caspar Clemens Mierau
 Dipl.-Kult. (Medien)
 official "Ubuntu member"
 ubuntu Deutschland e.V.
 Ubuntu Berlin
 c-base e.V.

_______________________________________________________________________
Info:    https://lists.silcnet.org/mailman/listinfo/silc-announce
Archive: https://lists.silcnet.org/pipermail/silc-announce
FAQ:     http://silcnet.org/support/faq/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJExBddbVIHJiaHn8RAuEQAJ0dtZsl9hOGEwtopDmSliLQo/zujACfSmB6
1zPS0eTXBCa2WfSql6Kozcg=
=EQzK
-----END PGP SIGNATURE-----