Re: Patch for server-name and server-file

Hallo

* Jörg Sommer ([email protected]) wrote [Thu, 080821 13:44]:

> Thomas Wiegner <[email protected]> wrote:
> > the old slrn had the following options in the configure script:

> > #v+
> >  --with-server-name=HOST Hostname of a default NNTP server
> >  --with-server-file=FILE File containing the hostname of an NNTP server
> > #v-

> There are much more options they must be set in slrnfest.h like
> OUR_ORGANIZATION and OUT_HOSTNAME. Should we add configure options for
> all these options, too? I don't think it's worth. For me, it's okay to
> modify slrnfeat.h.

No, but the big difference is, that these options once were part of
the configure script. From slrn's changes.txt:

#v+
Changes since 0.9.7.4

-1. Changes when building on Un*x:
  * The configure script accepts new options --with-server-name and
    --with-server-file (Matthias Friedrich).
#v-

It would be perfectly OK, just to add them in an outcommented state
to slrnfeat.hin like OUR_ORGANIZATION and OUT_HOSTNAME are. But not
everybody is capable and willingly to search the source code to find 
possible additional macros which one could set in slrnfeat.h.

BTW. From debian's slrn_0.9.9-1.diff.gz's /debian/rules:

#v+
+	./configure \
+		--with-slrnpull=/var/spool/slrnpull \
+		--with-gnutls \
+		--enable-inews --enable-spool \
+		--enable-setgid-code \
+		--prefix=/usr \
+		--mandir=/usr/share/man \
+		--sysconfdir=/etc/news \
+		--with-server-file=/etc/news/server \
+		--with-canlock \
+		--enable-iconv \
+		$(WITH_UUDEV) \
+		|| { rc=$$?; cat config.log; exit $$rc; }
#v-

Huh?


> > The attached patch enables these two options again in the configure
> > script.

> Your patch misses the changes in configure.ac

Ups. You are right, I don't speak m4, so hopefully someone more
competent than me can fix this.

Cheers,

 Thomas

-- 

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/