Re: Patches for slrn
Jörg Sommer <[email protected]>
| Newsgroups | gmane.network.slrn.user |
|---|---|
| Message-ID | <[email protected]> |
Hi John, "John E. Davis" <[email protected]> wrote: > Jörg Sommer <[email protected]> wrote: >> I've added two new patches to the list: >> Remove unused configure check for X libs and headers >> >> Slrn and slrnpull build fine without this check and I found no reference >> to X file in the source code. > > However some systems require additional networking libraries that this > check brings in. For example on solaris the macro will pull in the > socket and nsl libraries. Without it, slrn will not compile. This sounds strange: Include the X libraries to get network support. Isn't it better to include the network libraries directly? Are you sure this check doesn't pull in some other unneeded dependencies on X libraries? >> Correct format specifier for size_t >> >> On alpha, ia64 and s390 the type of size_t is not int but long unsinged >> int. The correct format specifier for printing size_t is %zu. >> > > This is not portable to all systems that slrn supports. A more > portable method is to use "%lu" and cast the size_t argument to an > unsigned long. Ten years ago I would have resisted using %u, because > it was not supported by all systems that slrn ran on. And what do you think about an (ugly) configure check with a define? Which system do you have in mind? > At this point I believe that I can safely assume that the target > system supports C90, but not C99. %z is also POSIX. But yes, there might be old systems. Bye, Jörg. -- Dein Gesicht wird dir geschenkt. Lächeln musst du selber! (Inga Hermann) ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/