Re: 0.3.4 released

Ray Lischner <[email protected]> wrote:
> On Monday 12 November 2001 10:38 am, Patrik RÃ¥dman wrote:
> > Well, it doesn't happen here... Does this happen every time HELLO
> > runs? What version of bash do you have installed?
> 
> I get the unexpected end of file error every time HELLO runs.
> 
> bash --version answers the following:
> GNU bash, version 2.05.0(1)-release (i386-suse-linux)

Aha! I was using bash 1.something, when I tried bash 2 I could reproduce the
problem. The cause was a missing semicolon, seems bash 2 is more anal about
that than bash 1. Revised patch to 0.3.4 is below, please report if it works.

Note that you may get ugly "Terminated" messages when running HELLO with
bash 2. They are harmless, but I'll see if I can turn them off somehow...

--- HELLO.in~	Mon Nov 12 23:16:54 2001
+++ HELLO.in	Mon Nov 12 23:16:47 2001
@@ -71,7 +71,7 @@
 #
 
 end () { log "$@" >&2; exit 0; }
-on_exit () { [ -e $tmp ] && rm -f $tmp; [ "x$lockf_proc" != x ] && kill $lockf_proc }
+on_exit () { [ -e $tmp ] && rm -f $tmp; [ "x$lockf_proc" != x ] && kill $lockf_proc; }
 
 trap on_exit 0
 
@@ -136,7 +136,7 @@
   date=`cat .last-list 2>/dev/null`
   nntp "NEWGROUPS ${date:-990101 000000}"
   [ x$CODE != x231 ] && end "Can't request newgroups:$CODE $SAID"
-  inform "$cmd" || [ -s $tmp ] && end "Unable to forward results"
+  inform "$cmd" || { [ -s $tmp ] && end "Unable to forward results"; }
   update request-newgroups
 fi
 

-- 
  Patrik Rådman  ·  patrik at iki dot fi  ·  http://www.iki.fi/patrik/
  "We're not in the past or the present anymore.  This is the future!"