Re: bug in testing of message id's
Patrik Rådman <[email protected]>
| Newsgroups | gmane.network.sn |
|---|---|
| Message-ID | <[email protected]> |
Chris Niekel <[email protected]> wrote: > On Tue, Apr 20, 2004 at 02:58:40PM +0300, Patrik R?dman wrote: > > Without applying the patch, or reading it in context, this keeps the > order of the '-' and '.' the same, so [email protected] would fail? I looked Domain names cannot begin or end with a '-'. > at the NNTP-rfc and they're very, very liberal in the message id's. > Okay, they just point at other RFC's, but almost anything seems to be > allright. > > I haven't looked at how what the id's are used for in the code, but > wouldn't a <anything>@<anything> be enough of a test on incoming > messages? The whole function seems overly strict, with a special test > for @[num.num.num.num].. If the message-id arrives, a lot of other > newsservers have already considered the message-id to be acceptable. Not if the message came through snmail... Maybe the Message-ID check is overly strict, but I'd prefer not to mess with it too much... "If it ain't broke, don't fix it." :) -- Patrik Rådman · patrik at iki dot fi · http://www.iki.fi/patrik/ "I know this because Tyler knows this."