Re: port limitation to int16

John Schultz <[email protected]> Thu, 8 Aug 2013 10:40:51 -0400
Newsgroups gmane.network.spread.user
Message-ID <[email protected]>
Looks like we had roughly the same idea! :)

I think changing the underlying types that hold ports is probably safer because if somewhere someone does:

int16u port;

...

printf("%d", port);

I think C does the right thing.  

Cheers!

-----
John Lane Schultz
Spread Concepts LLC
Cell: 443 838 2200

On Aug 8, 2013, at 10:20 AM, Johannes Wienke wrote:

Hi again,

On 08/08/2013 03:41 PM, Johannes Wienke wrote:
[..]
> There is an integer overflow in the
> daemon and this does not only exist in the printing. Actually the socket
> file in /tmp is really called -17536. The client API doesn't seem to
> have this overflow and tries to correctly find a file with name 48000.

Attached is a patch fixing the problems.

Kind regards,
Johannes

<high-port-fix.patch>