Re: [tin 2.4.3] snapshots - please test

--===============8840513299203388063==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7"
Content-Disposition: inline


--GRPZ8SYKNexpdSJ7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jul  3 17:13, Urs Jan=C3=9Fen wrote:
> In <[email protected]>, Corinna Vinschen wrote:
> > Just built on Cygwin.  Looks good.  Apart from a few "unused variable"
>=20
> Thanks, for the feedback, those are "normal" and depend on
> --enable-nntp or --enable-nntp-only.

I guessed so.

> > and "unorm_normalize_62 is deprecated" warnings,
>=20
> this is on the TODO list
>=20
> | o  add check for ICU unorm2.h/unorm2_normalize(); prefer it over
> |    ICU unorm.h/unorm_normalize()
>=20
> volunteers? ,-)

Hmm, the call has changed significantly.  Not that easy...

> > there's one which is ...interesting:
> >=20
> > pcre/pcre_study.c:419:35: warning: =E2=80=98<<=E2=80=99 in boolean cont=
ext, did you mean =E2=80=98<=E2=80=99 ? [-Wint-in-bool-context]
> >              if ((tcode[c/8] && (1 << (c&7))) !=3D 0)
> >                                 ~~~^~~~~~~~~
> >=20
> > The && looks wrong.  In the equivalent piece of code in upstream
> > pcre-8.42 this reads:
> >=20
> >              if ((map[c/8] & (1 << (c&7))) !=3D 0)
>=20
> the included pcre source is very outdated (> 10 years old now) and should
> either be updated or dropped (at least any system wide installed version
> should be preferred).

Dropping the included pcre would be preferrable, otherwise you get
outdated code by default.  It's even dangerous as fallback.  Better to
bail out from configure if the system has no libpcre installed.

>=20
> | o  clean up included pcre stuff and update to >=3D pcre-8.42
> |
> | o  and pcre2 support (new API)
> |    <http://www.pcre.org/current/doc/html/>
>=20
> But I'll fix that in the code. Thanks for the hint.
> =20
> > For the Cygwin release I will switch to --with-pcre for the time being.
>=20
> This is highly recommended.

Thanks,
Corinna

--=20
Corinna Vinschen
Cygwin Maintainer
Red Hat

--GRPZ8SYKNexpdSJ7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAls7nHIACgkQ9TYGna5E
T6DS1Q//dhT1HozVt7MdPV2bGYdpxQsD7Bh0RxAgNRBTtBnaCEpAIE61U85S6dm2
Mq2mrWOD/89YEfl/m1NlKUfM1gUHKHe/b9TJvJCcoWXtDPIYOElv3I8h17p7p09Y
MUX6m2rwUqMsLAj3OO8GujWQCn8Zg7OdcrzNulL7pRK/KOV73VQxW8bQcbsLU1MN
DdG58ZrBlzN6J5xyoJO/kpaFJYhoV+l3e4vSl1zq8SF2JwPXqYzoIyTOZ6CoKghM
JpALWWex4rma9MOY7p4jKNtfx1JHFzeiGHkZ+70HKXmUHl6nGD6QMtuVHrEYLmL9
FO9Dr8qGvqYsFB5O3aMS7QO67/UniKwNByuZswOhS8V0N8kY2aYKbmL3sz7/gsII
+RdUdkMHLiVN+k6yGDfsQqO/0qS1UoHk8EVLwMqWprK7kzlLGD2cxR0jHWVCNpZD
nTraz+LqMNtlcsUO95JeyQ+hZs1zPfmp57aZ/5dAIK/EqRklUrJjWBXvMgzvMhI3
hUIH5JWdeatQ2oGwde7Zr9wHWWsSBfysCc5iT9xTm8IA2NgYa3TYlA4/uW5hp6OW
bkehNSdpFvJgXOnV4A+dEuEedIvUkdKM0HFv3pdJ9NQ13c3UHp/HAoIxlXVX4CkK
fW/T99pq73gMGWY1W5pQELjrYkWAbIxOb96C8q4ugkRyFngyILE=
=SDWJ
-----END PGP SIGNATURE-----

--GRPZ8SYKNexpdSJ7--


--===============8840513299203388063==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KdGluLWRldiBt
YWlsaW5nIGxpc3QKdGluLWRldkB0aW4ub3JnCmh0dHA6Ly9saXN0cy50aW4ub3JnL2NnaS1iaW4v
bWFpbG1hbi9saXN0aW5mby90aW4tZGV2Cg==

--===============8840513299203388063==--