Re: [tin 2.4.3] snapshots - please test

Corinna Vinschen <[email protected]> Wed, 4 Jul 2018 13:00:24 +0200
Newsgroups gmane.network.tin.devel
Message-ID <[email protected]>
--===============8752108923591313335==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="jB+02Y6wHc2pEa2x"
Content-Disposition: inline


--jB+02Y6wHc2pEa2x
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jul  4 09:23, Urs Jan=C3=9Fen wrote:
> In <[email protected]>, Corinna Vinschen wrote:
> >> | o  add check for ICU unorm2.h/unorm2_normalize(); prefer it over
> >> |    ICU unorm.h/unorm_normalize()
> >> volunteers? ,-)
> >=20
> > Hmm, the call has changed significantly.  Not that easy...
>=20
> that's why it's still on the todo list ,-)
>=20
> >> > pcre/pcre_study.c:419:35: warning: =E2=80=98<<=E2=80=99 in boolean c=
ontext, did you mean =E2=80=98<=E2=80=99 ? [-Wint-in-bool-context]
> >> >              if ((tcode[c/8] && (1 << (c&7))) !=3D 0)
> >> >                                 ~~~^~~~~~~~~
> >> > The && looks wrong.  In the equivalent piece of code in upstream
> >> > pcre-8.42 this reads:
> >> >=20
> >> >              if ((map[c/8] & (1 << (c&7))) !=3D 0)
>=20
> btw. that one was fixed in pcre-8.10
>=20
> >> the included pcre source is very outdated (> 10 years old now) and sho=
uld
> >> either be updated or dropped (at least any system wide installed versi=
on
> >> should be preferred).
> > Dropping the included pcre would be preferrable, otherwise you get
>=20
> I'd like to see the current pcre-8.x included instead - pcre-8 is
> feature complete and only gets bug fixes...

Features are not the problem, security fixes are.  External code
bundled into a subdir of "my project" is prone to get outdated
and forgotten, as the current case proves.  Better to *not* bundle
it in the first place and to use the system version instead, which
at least has a chance of regular security updates as necessary.


Corinna

--=20
Corinna Vinschen
Cygwin Maintainer
Red Hat

--jB+02Y6wHc2pEa2x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAls8qMcACgkQ9TYGna5E
T6AiPQ//T1vG45p29BYMSRxD0do8TS3EnuHK7DD2Y/EjDS0JIaA4Tejq/fEwdtMB
Rh5gPa3eWZyGuV9L+hS1mBmnX3lcxVfXrksts/oeizd6hLeB/nCfREjbTF+3M/zu
bJkpCz8RFEA9Rf4DxE9NK0PO6Vk9rOs8slOJiA5nWhrHrja0nKmHj7IWn5i9a945
pvN8TbytBVwNK8nH9OAWztYs+nTSuh/jII+enZxVGdpNynEsGWYLVq9Jb0Z+uhyx
7yGCOTwFxdQGkgghpJO56wuWMLF9HLNPILzKnjpuDPn/nJgazMbWkLZwLSYqDbS3
34bdjUSgTXIxZqmxxuVtTfbO6acbjjgbc+Sv6EJwjFLmve/CmykgBRg/3XjPxCBu
SY/mb3uWSTNgFLDYrnAh6osupBBlzjoztHcd9Iv4FgrwNEI4zr2cYkxxHQo/MNnH
4rtPXU610Me9bSNeAaQpbXmjxcoXCYonBe+04NRh3RmjaXgNlZiVJMxdvyBAuOrZ
fr0gusxzS4uTxj05RS7KETAVbuCGJjcNwCuYJyo1D64panGaD9jplsPdyA0hO2/g
uvvRjamh/BFw8Tq3uMy36gB/csDI0Hx4w5V9VnYUvhi4Q2/dKgvQex4TzRW0gg0h
TKvq9vUDkhxKq4Up9pAqYOvEitLD+1bJZom3NCTV0NA8l3D52dc=
=JRvq
-----END PGP SIGNATURE-----

--jB+02Y6wHc2pEa2x--


--===============8752108923591313335==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KdGluLWRldiBt
YWlsaW5nIGxpc3QKdGluLWRldkB0aW4ub3JnCmh0dHA6Ly9saXN0cy50aW4ub3JnL2NnaS1iaW4v
bWFpbG1hbi9saXN0aW5mby90aW4tZGV2Cg==

--===============8752108923591313335==--