Re: [PATCH] prompt_yn() accepts only keys from prompt_keys

On Sat, Mar 12, 2005 at 01:11:51AM +0100, Michael Bienia wrote:
> > > - the same but with merging and the merged lines are written at the end
> > >   of the file (or block assuming the user hasn't changed the layout of
> > >   the keymap file)
> > >   (middle effort)
> The attached patch implements this solution (the patch is against the
> latest snapshot with your patch). I've tested the patch primarily with 
> keymap.sample from tin 1.7.7 (keymap V1.0.0) hence it would be good if
> someone could test it also with a keymap which is in real use.

looks fine to me except a few small things:
- you've removed the upgrade-var in process_keymap_file(), that way
  we can no longer detect version downgrades. I've fixed that.

- there are several 'pending' keyrenames which still should to be done:
| o  - join GROUP_EDIT_FILTER, THREAD_EDIT_FILTER, PAGE_EDIT_FILTER,
|      SELECT_EDIT_FILTER to a single 'key' (EDIT_FILTER).
|    - the various filter keys are named a bit inconsistent, currently
|      we have iKeyGroupQuickAutoSel, iKeyGroupQuickKill,
|      iKeyPageQuickAutoSel, iKeyPageQuickKill and iKeyGroupKill,
|      iKeyGroupAutoSel, iKeyPageAutoKill, iKeyPageAutoSel. in actual
|      fact iKeyPageAutoKill is a misnomer and should be iKeyPageKill,
|      but the whole naming looks a bit odd. the *Quick* keys do add a
|      filter/scoring entry and the others do call the filter/scoring
|      menu. It would be nice if the name would express that. e.g.
|      rename them to something like *QuickFilter{Kill,Select} and
|      *MenuFilter{Kill,Select}. and as the default values for those
|      keys arn't used anywhere else we could drop their scope prefix
|      which would lead us to something like
|      iKeyQuickFilter{Kill,Select} and iKeyMenuFilter{Kill,Select}

urs

p.s.: I have no idea how to solve the PostponeOverride / PromptYes
      issue.