Re: BUG REPORT tin 1.9.1 release 20060409 ("Benmore") [UNIX]

On Fr, Apr 21, 2006 at 12:07:21 +0200, Sven Gottwald wrote:
> After starting tin I go to de.soc.netzkultur.umgangsformen and press "u".
> tin says "Can't find base article 121".  After pressing "u" again tin crashes:
> 
> ---SNIP---
> Program received signal SIGFPE, Arithmetic exception.
> 0x0804df4a in thread_by_percentage (group=0x402bf4a0) at art.c:773
> 773                     if ((unmatched * 100) / slen > percentage) {
> (gdb) bt
> #0  0x0804df4a in thread_by_percentage (group=0x402bf4a0) at art.c:773
> #1  0x0804e954 in make_threads (group=0x402bf4a0, rethread=1) at art.c:1097
> #2  0x080697bd in group_page (group=0x402bf4a0) at group.c:641
> #3  0x080ac34a in read_groups () at select.c:1035
> #4  0x080acb30 in select_read_group () at select.c:1261
> #5  0x080aa33e in selection_page (start_groupnum=0, num_cmd_line_groups=0) at select.c:218
> #6  0x0807ac5f in main (argc=1, argv=0xbffff4b4) at main.c:395
> (gdb) frame 0
> #0  0x0804df4a in thread_by_percentage (group=0x402bf4a0) at art.c:773
> 773                     if ((unmatched * 100) / slen > percentage) {
> (gdb) print unmatched
> $1 = 14
> (gdb) print slen
> $2 = 0
> (gdb) print percentage
> $3 = 25
> ---SNAP---

divison by zero caused by article <[email protected]>
("empty" subject). the following patch should fix this (for the stable
branch as well):

--- art.c	2006-02-15 19:44:38.000000000 +0100
+++ art.c	2006-04-21 14:40:38.854403798 +0200
@@ -769,6 +769,8 @@
 		 * them matching.
 		 */
 		slen = strlen(arts[base[root_num]].subject);
+		if (!slen)
+			slen++;
 		unmatched += abs(slen - strlen(arts[i].subject));
 		if ((unmatched * 100) / slen > percentage) {
 			/*