Re: [PATCH] Merge tinrc.*_goto_next_unread to tinrc.goto_next_unread

On Wed, Jun 28, 2006 at 12:49:05PM +0200, Michael Bienia wrote:

a couple of flaws

diff -Nurp tin-1.9.2/src/config.c tin-1.9.2.patched/src/config.c
--- tin-1.9.2/src/config.c	2006-06-21 01:15:44.000000000 +0200
+++ tin-1.9.2.patched/src/config.c	2006-06-27 17:01:29.662130875 +0200
@@ -406,6 +406,9 @@ read_config_file(
 			if (match_integer(buf, "getart_limit=", &tinrc.getart_limit, 0))
 				break;
 
+			if (match_integer(buf, "goto_next_unread", &tinrc.goto_next_unread, NUM_GOTO_NEXT_UNREAD))
+				break;
+

that should read (with the = sign) otherwise it will not match
+			if (match_integer(buf, "goto_next_unread=", &tinrc.goto_next_unread, NUM_GOTO_NEXT_UNREAD))


@@ -1743,6 +1735,12 @@ rc_update(
 					break;
 				break;
 
+			case 'p':
+				if (match_boolean(buf, "pgdn_goto_next=", &pgdn_goto_next))
+					set_goto_next_unread = TRUE;
+					break;

missing {}

+				break;
+
 			case 'q':
 				if (match_boolean(buf, "quote_signatures=" , &quote_signatures))
 					break;
@@ -1751,6 +1749,9 @@ rc_update(
 				break;
 
 			case 's':
+				if (match_boolean(buf, "space_goto_next_unread=", &space_goto_next_unread))
+					set_goto_next_unread = TRUE;
+					break;

missing {}

 				if (match_boolean(buf, "save_to_mmdf_mailbox=", &save_to_mmdf_mailbox))
 					break;
 				if (match_boolean(buf, "show_last_line_prev_page=", &show_last_line_prev_page))
@@ -1762,6 +1763,9 @@ rc_update(
 				break;
 
 			case 't':
+				if (match_boolean(buf, "tab_goto_next_unread=", &tab_goto_next_unread))
+					set_goto_next_unread = TRUE;
+					break;

missing {}


 				if (match_boolean(buf, "thread_articles=", &thread_articles))
 					break;
 				break;
diff -Nurp tin-1.9.2/src/lang.c tin-1.9.2.patched/src/lang.c
--- tin-1.9.2/src/lang.c	2006-06-21 01:15:57.000000000 +0200
+++ tin-1.9.2.patched/src/lang.c	2006-06-27 23:40:45.640880593 +0200
+# Possible values are (the default is marked with *):\n\
+#   0 = nothing\n\
+#   1 = PAGE DOWN\n\
+#   2 = TAB\n\
+# * 3 = PAGE DOWN or TAB\n")
 };

the default is 2, not 3