Re: Patch

On Sun, Sep 17, 2006 at 01:19:10AM +0200, Dirk Nimmich wrote:
> Additionally I tried to fix the auth bug you described in TODO but I
> don't think I have understood the problem. There's no way to edit

the problem is, if you put the wrong username in .newsauth - the server
says Authorisation failed (ok) and then tin ask for the username.
now you give the correct username (and password) but tin still uses the
_old_ values and so you enter the next round of retrys. tin promts for
username/password and now the correct username is used and authorization is
successfull.

with your patch you do not get the chance to correct the username/password
(this is ok for the case where username/password is comming from
~/.newsauth), but if the server is not in ~/.newsauth but requires auth, tin
now dosn't ask for the username thus is the username on the server doesn't
match the local account name you can not log in (unless you put the server
into newsauth).

> the username in the first pass because I assumed that if there is a
> .newsauth file there's no need to do so - everything should just be
> correct in it, and you only need to interactively change things when
> something goes wrong.
> 
> Nevertheless see the second patch for auth.c that should fix some
> other minor bug (authentication with cached values is always
> considered successful) and moves some code around. ;-) It now also
> allows to specify if credentials must be supplied manually. Have
> fun, play around and try if your problem is solved, but be aware
> that I only made sure that the code compiles, I haven't tested it at

and another bug:

connect to a server which doesn't (always) require authentication but you have a
account for (i.e. no auth if comming from truseed ips, auth if comming from
dialups) and force authentication andf give the wrong password in the
first pass

./tin -A
[...]
Server expects authentication.
    Please enter password: wrong
Authorisation failed for user: urs
Server expects authentication.
    Please enter username: urs
    Please enter password: rigth
Authorised for user: urs

now curses is in the wrong state and the keybod input is echoed at the
bottom of the screen (tin is configured --with-screen=ncursesw).

(without your patch this causes an endless loop "Authorisation failed for
user: urs" - so at least it doesnt make things worse ,-)

> all (lack of server that requires authentication ;-).

if you like an account on a server which requires auth - no problem
(inn 2.2.3 and/or inn 2.4.1)

urs
-- 
"Only whimps use tape backup: _real_ men just upload their important stuff
 on ftp, and let the rest of the world mirror it ;)" - Linus