Re: Patch

Urs Janßen wrote:
> In <[email protected]>, Dirk Nimmich wrote:
> > +      BUG. resent command on 503 error
> 
> this is needed to avoid possible article loss after a connection
> timeout with e.g. inn-2.2.3 "503 Timeout after 600 seconds, closing
> connection." (after the timeout the first articles is
> marked read but not displayed as tin thinks it unavailable), reverting
> this change should fix this:

Sorry, but IMO this is the wrong way to fix this. The "article loss"
must be handled outside of the get response function, and not only
for any 503 error code (which is a bug in INN 2.2.3, not in tin) but
for any unexpected response code/connection loss (the server may
have closed the connection or it may be lost due to other
circumstances). 503 is a generic error code also used for unknown
(sub) commands like after AUTHINFO GENERIC ANY; you normally don't
want to send the wrong command again because this may cause a loop
or an unexpected state on the server side (AUTHINFO again).

The more I look into the NNTP handling code (mostly the response
code handling and reconnecting) the more I see a need for a complete
rewrite (see also my other mail).

> > +      ADD. rewrote NGLIMIT handling
> 
> in mailing_list groups this leads to a crash as the pointers are
> never initialized
> 
> > -       char *ngptrs[NGLIMIT], *ftngptrs[NGLIMIT];
> > +       char **newsgroups;
> > +       char **followupto;
> 
> set to NULL

Ok.