Re: [PATCH] HAVE_MKSTEMP tries to kill not existent tmp-file in?$HOME and $TMPDIR (1.9.2)

Urs Janßen <[email protected]> Fri, 25 May 2007 17:30:16 +0200
Newsgroups gmane.network.tin.devel
Message-ID <[email protected]>
On Fri, May 25, 2007 at 05:22:28PM +0200, Rado S wrote:
> Oh, right ... but there is also a final check for fd==-1 after all
> the #ifdef, where it says "Couldn't create tmpfile...", have you
> removed that? It would be redundant.

it's used to issue the less specific error-message

> > cause errno might be clobbered by the next system call and we need
> > it's original val in the error message.
> I understand the principle, but in this case there is no syscall
> before it's being printed.

defensive coding

> Fine ... but ... when tin reports "Article posted:" it shows a
> msg-ID generated with the domain name of the server: does tin create
> it that way or is this reported back from the server?

reported back from the server

urs