Re: tin 1.8.3 and 1.9.3 release 20080423: some subjects are initially invisible at group level

On Sun, Apr 27, 2008 at 08:19:52PM +0200, Dennis Preiser wrote:
> Dear all,
>
> I have noticed that after entering a group some subjects are not shown at 
> group level. This happens for instance in uk.comp.sys.mac. Scrolling thru 
> the list of threads shows some empty subject fields. After displaying any 
> article in this group and going back to group level all subjects are 
> visible.
>
> Here is a Message-ID from an articles who's subject is initially invisible:
>
> Newsgroups: uk.comp.sys.mac
> Message-ID: 
> <5240eb63-6288-45b5-abda-bb6ac3f05289@u36g2000prf.googlegroups.com>
>
> The subject of this article looks like this (copied from the "show article 
> in raw-mode" view):
>
> Subject: 9, I do all of my Chronoswiss Replica Watches - CS002 and other
> \011replica watches shopping at 
> http://watchec.com/wholesale_watches/chronoswiss-replica-watches.html,
> \011though it is across the country, It is extremly knowledgeable on their 
> lines
> \011and has great access to just about all products as well as providing 
> excellent
> \011products support..
>
> Yes, it's SPAM but I think tin should display the subject nevertheless.
>
> I have tested with tin 1.8.3 and 1.9.3 release 20080423 and both showing 
> the same behavior.

the patch below should fix this

--- group.c	2008-04-17 12:25:53.000000000 +0200
+++ group.c	2008-04-29 11:45:49.851223318 +0200
@@ -1258,7 +1258,7 @@
 	if (sbuf.multipart_have > 1) /* We have a multipart msg so lets built our new header info. */
 		build_multipart_header(arts_sub, len_subj, arts[j].subject, sbuf.multipart_compare_len, sbuf.multipart_have, sbuf.multipart_total);
 	else
-		strncpy(arts_sub, arts[j].subject, sizeof(arts_sub) - 1);
+		STRCPY(arts_sub, arts[j].subject);
 
 #ifndef USE_CURSES
 	buffer = screen[INDEX2SNUM(i)].col;