[bug] attributes stuff in options_menu.c broken

Dennis Preiser <[email protected]> Fri, 31 Oct 2008 20:49:06 +0100
Newsgroups gmane.network.tin.devel
Message-ID <[email protected]>
Hello,

currently I'm incorporating tinrc-variables into the attributes  
system. During testing I ran into trouble with the  
options_menu.c:change_config_file()-code.

The following lines:

group->attribute->ATTRIBUTE = tinrc.ATTRIBUTE;
glob_attributes.ATTRIBUTE = tinrc.ATTRIBUTE;

are useless in my mind.

If you change an option at group-level, the first line overwrites a  
attribute set from the attributes-file (if present).

If you change an option at group-level, the second line causes tin to  
write this changed value to all scopes which matches this group (if  
this option is not set in the attributes-file for those scopes).

I'm in favor of wiping out all attributes-specific stuff from  
options_menu.c:change_config_file() and call read_attributes_files()  
in options_menu.c this way:

case GLOBAL_QUIT:
	write_config_file(local_config_file);
	read_attributes_files();
	break;

Is this acceptable?

Dennis