Thoughts about 'skip next block of included text'

Dennis Preiser <[email protected]> Sat, 4 Apr 2009 12:39:30 +0200
Newsgroups gmane.network.tin.devel
Message-ID <[email protected]>
Hello,

in some groups ppl. often quote the whole article and write their  
stuff below. After one or two article in a thread the first page in  
article pager contains only quoted stuff. The appropriate function to  
handle this seems to be 'PageSkipIncludedText', usually bound to ':'.

The man page says:

        PageSkipIncludedText ':'
                  Skip  to  the  end  of the quoted text-block in  
this article.
                  Quoted  text  is  everything   which   matches    
quote_regex,
                  quote_regex2 or quote_regex3.

The logic behind 'PageSkipIncludedText' is to search and jump to the  
next non-quoted line, which can be the first line currently displayed  
in the pager.

Unfortunately, the first line of each article is (usually) the  
quotation line or a header (from news_headers_to_display) which is  
not a quoted line => 'PageSkipIncludedText' doesn't work on the first  
page.

The second issue is that 'PageSkipIncludedText' only works once per  
article. If a quoted block was skipped, the first line in the pager  
is a non-quoted line => 'PageSkipIncludedText' doesn't skip the next  
block of quoted lines.

I'm not sure whether this is a bug or a feature. I think it's a bug.

With the attached patch 'PageSkipIncludedText' jumps to the first non- 
quoted line *after* the next block of quoted lines. One can now read  
the whole article skipping all the quoted stuff by using  
'PageSkipIncludedText' multiple times.

The patch is against the latest snapshot.

Dennis
20090404.diff.gz (application/x-gzip, 721 B) - not displayed