Re: [PATCH] batch mode and cmd-line option treatment

On 18.07.2009, at 18:58, Urs Janßen wrote:

> On Sat, Jul 18, 2009 at 02:55:29PM +0100, Jason Faultless wrote:
>>> The directory handling seems to be broken somewhere. Try setting
>
> I've used TIN_HOMEDIR quiet a lot in the past for testing and never  
> noticed
> any defects.
>
>>> TIN_HOMEDIR to a nonexistent dir.
>
> can't see any big defect here, it can't reed the files from the  
> specified
> location -> uses internal defaults. can't save to the specifed  
> location ->
> uses internal defaults (overwrited the old files).

OK. I've assumed tin should create the dir if necessary (and possible).

> if remove the dependency for write_config_file() from
> create_mail_save_dirs() we should do something like
>
>     create_mail_save_dirs();
>
>     if (created_rcdir) /* first start */
>         write_config_file(local_config_file);
>
> instead.

That's a better solution than depending on create_mail_save_dirs(),  
because it has returned TRUE only if mail- or savedir does not exist.  
dirs were present -> local_config_file was not written.


Dennis