Re: [PATCH] Two TODOs
Urs Janßen <[email protected]> Wed, 10 Feb 2010 11:10:43 +0100
| Newsgroups | gmane.network.tin.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Feb 06, 2010 at 12:11:06AM +0100, Dennis Preiser wrote: > cancel_article() needs a valid pgart, so art_open() and art_close() are > necessary to populate (and clear) pgart. art_open() calls, among other > things, cook_article(), which is unnecessary in this case. I am not sure > whether this overhead is acceptable here. On the other hand, cancelling > an article is not the usual task, so this might be OK. IMHO this is ok, thanks for your patch (I've added the new keys to tin(5)). urs -- "Only whimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" - Linus