Re: [patch] tux3-2.4.23-A1

Ingo Molnar wrote:

>i've merged the latest Tux bits to 2.4.23:
>
>	redhat.com/~mingo/TUX-patches/tux3-2.4.23-A1
>
>the user module protocol version increased to 3, due to 64-bitness
>cleanups in the API. Various other fixes were merged as well. If you are
>using modules then you'll need an updated userspace package as well:
>
>	redhat.com/~mingo/TUX-patches/tux-3.2.15.tar.gz
>
>let me know if there are any regressions.
>
>	Ingo
>
>  
>
First of all thank you for your work.

Now, I can't compile the 2.4.23 kernel with the patch tux3-2.4.23-A1,
the result is:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.23/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe
-mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix include
-DKBUILD_BASENAME=ksyms  -DEXPORT_SYMTAB -c ksyms.c
ksyms.c:165: `sys_read' undeclared here (not in a function)
ksyms.c:165: initializer element is not constant
ksyms.c:165: (near initialization for `__ksymtab_sys_read.value')
ksyms.c:166: `sys_write' undeclared here (not in a function)
ksyms.c:166: initializer element is not constant
ksyms.c:166: (near initialization for `__ksymtab_sys_write.value')
ksyms.c:167: `sys_dup' undeclared here (not in a function)
ksyms.c:167: initializer element is not constant
ksyms.c:167: (near initialization for `__ksymtab_sys_dup.value')
ksyms.c:168: `sys_chroot' undeclared here (not in a function)
ksyms.c:168: initializer element is not constant
ksyms.c:168: (near initialization for `__ksymtab_sys_chroot.value')
ksyms.c:169: `sys_chdir' undeclared here (not in a function)
ksyms.c:169: initializer element is not constant
ksyms.c:169: (near initialization for `__ksymtab_sys_chdir.value')
ksyms.c:170: `sys_fcntl' undeclared here (not in a function)
ksyms.c:170: initializer element is not constant
ksyms.c:170: (near initialization for `__ksymtab_sys_fcntl.value')
make[2]: *** [ksyms.o] Error 1

Those definitions are added by your patch as:
EXPORT_SYMBOL_GPL(sys_read);
EXPORT_SYMBOL_GPL(sys_write);
EXPORT_SYMBOL_GPL(sys_dup);
EXPORT_SYMBOL_GPL(sys_chroot);
EXPORT_SYMBOL_GPL(sys_chdir);
EXPORT_SYMBOL_GPL(sys_fcntl);
EXPORT_SYMBOL_GPL(do_pipe);

I have tried to follow the roots of this by reading about
EXPORT_SYMBOL_GPL vs EXPORT_SYMBOL, and poking around the tux3 patch,
but I still have no solution, and I will not touch it again until next
year ;-)

-- 
Jorge Nerin
<[email protected]>