Re: [patch] tux3-2.4.23-A2

Ingo Molnar wrote:

>* Jorge Nerin <[email protected]> wrote:
>
>  
>
>>Now, I can't compile the 2.4.23 kernel with the patch tux3-2.4.23-A1,
>>the result is:
>>    
>>
>
>there's a compilation problem in the -A1 patch if modules are enabled,
>i've uploaded -A2 with the fix:
>
>	redhat.com/~mingo/TUX-patches/tux3-2.4.23-A2
>
>but, the sys_read/sys_write compilation problems are weird - fs.h is
>included in kernel/ksyms.c and fs.h defines the sys_read/sys_write
>function prototypes.
>
>please re-try with -A2 and a clean tree (make mrproper at least, but
>fresh tree is best) - do you still get these compilation problems?
>
>	Ingo
>  
>

I get the same results with a fresh 2.4.23 tar.bz2 kernel validated by 
gpg from kernel.org with a system with make 3.79.1, gcc 2.96, kgcc 
egcs-2.91.66

The only strange thing I could notice is that while aplying the path it 
gave me a warning:

patching file include/linux/dcache.h
patching file include/linux/errno.h
patching file include/linux/fs.h
Hunk #1 succeeded at 855 (offset -8 lines).
Hunk #2 succeeded at 1494 (offset -1 lines).
patching file include/linux/kernel_stat.h
patching file include/linux/mmzone.h
patching file include/linux/sched.h

I do not have .rej files, but perhaps your kernel is different from 
mine, or do I need any previous patch?

Results with gcc:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.23/include -Wall 
-Wstrict-prototypes -Wno-
trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common 
-fomit-frame
-pointer -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc 
-iwithprefix i
nclude -DKBUILD_BASENAME=ksyms  -DEXPORT_SYMTAB -c ksyms.c
ksyms.c:165: `sys_read' undeclared here (not in a function)
ksyms.c:165: initializer element is not constant
ksyms.c:165: (near initialization for `__ksymtab_sys_read.value')
ksyms.c:166: `sys_write' undeclared here (not in a function)
ksyms.c:166: initializer element is not constant
ksyms.c:166: (near initialization for `__ksymtab_sys_write.value')
ksyms.c:167: `sys_dup' undeclared here (not in a function)
ksyms.c:167: initializer element is not constant
ksyms.c:167: (near initialization for `__ksymtab_sys_dup.value')
ksyms.c:168: `sys_chroot' undeclared here (not in a function)
ksyms.c:168: initializer element is not constant
ksyms.c:168: (near initialization for `__ksymtab_sys_chroot.value')
ksyms.c:169: `sys_chdir' undeclared here (not in a function)
ksyms.c:169: initializer element is not constant
ksyms.c:169: (near initialization for `__ksymtab_sys_chdir.value')
ksyms.c:170: `sys_fcntl' undeclared here (not in a function)
ksyms.c:170: initializer element is not constant
ksyms.c:170: (near initialization for `__ksymtab_sys_fcntl.value')
make[2]: *** [ksyms.o] Error 1


Results with kgcc:

kgcc -D__KERNEL__ -I/usr/src/linux-2.4.23/include -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer 
-fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe  
-march=i586   -nostdinc -iwithprefix include -DKBUILD_BASENAME=ksyms  
-DEXPORT_SYMTAB -c ksyms.c
ksyms.c:165: `sys_read' undeclared here (not in a function)
ksyms.c:165: initializer element for `__ksymtab_sys_read.value' is not 
constant
ksyms.c:166: `sys_write' undeclared here (not in a function)
ksyms.c:166: initializer element for `__ksymtab_sys_write.value' is not 
constant
ksyms.c:167: `sys_dup' undeclared here (not in a function)
ksyms.c:167: initializer element for `__ksymtab_sys_dup.value' is not 
constant
ksyms.c:168: `sys_chroot' undeclared here (not in a function)
ksyms.c:168: initializer element for `__ksymtab_sys_chroot.value' is not 
constant
ksyms.c:169: `sys_chdir' undeclared here (not in a function)
ksyms.c:169: initializer element for `__ksymtab_sys_chdir.value' is not 
constant
ksyms.c:170: `sys_fcntl' undeclared here (not in a function)
ksyms.c:170: initializer element for `__ksymtab_sys_fcntl.value' is not 
constant
make[2]: *** [ksyms.o] Error 1

-- 
Jorge Nerin
<[email protected]>