call for review and testing: ACLs and extended attributes
Greg Troxel <[email protected]> Fri, 22 Jul 2022 14:05:19 -0400
| Newsgroups | gmane.network.unison.devel |
|---|---|
| Message-ID | <[email protected]> |
I have just been merging things without real review when some
conditions are met:
- successful CI (including old-version regression)
- I understand the high-level approach of the change
- I have skimmed it
- The submitter has a track record of a very low rate of breakage in
recent history of merged PRs
- it doesn't seem super complicated
There are two PRs that are on the more complicated side and I would like
help with code review and testing. (I haven't skimmed yet, but will.)
See the notes; running this will upgrade archives to a form that can't
be used by the tip of master, but I am pretty sure you can use it on
test roots only with no trouble. (My approach when doing any kind of
upgrade is to make sure everything is 100% synced before changing
anything; then archives can just be deleted and regenerated.)
ACL: https://github.com/bcpierce00/unison/pull/359
xattr: https://github.com/bcpierce00/unison/pull/368
(Also note that there are test commits that won't get merged.)
I am unclear if these use the same archive-format extension and how it
works if you run both. Maybe Töivo can comment?
Testing on other than the triculture (like a monoculture, but with 3 :-)
is especially welcome.
I intend to test them myself, which may lead to a subroutine call to
grasp ACLs and xattr, which are newfangled to me and something I don't
tend to use (although clearly useful), and if by the time that happens,
there are no comments, I'm going to merge anyway.
Thanks,
Greg
_______________________________________________
Unison-hackers mailing list
[email protected]
https://LISTS.SEAS.UPENN.EDU/mailman/listinfo/unison-hackers
signature.asc
(application/pgp-signature, 194 B)
-----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQS7wyAjWilQwVHG9Vsf2nroCY7WDgUCYtrm3wAKCRAf2nroCY7W DhiSAJ0bgBcHUem3hQ2zzd3kVSlrxNkZkwCeI1On46/siJYtHjUoA38K6FYYGV4= =7N2c -----END PGP SIGNATURE-----