Re: Wierd traceback on update [patch does not work]

The patch hunter sent out won't quite do what we want - I'll try to work
something up this weekend.  Gimme at least until this time tomorrow.

On Fri, 17 Jan 2003, John Stauffacher wrote:

> After applying the patch Hunter sent out I still get:
> 
> Traceback (innermost last):
>   File "/usr/sbin/cadmin", line 325, in ?
>     main()
>   File "/usr/sbin/cadmin", line 260, in main
>     mychan.update()
>   File "/usr/share/current/channel.py", line 182, in update
>     self._addRpmDir(dir)
>   File "/usr/share/current/channel.py", line 624, in _addRpmDir
>     self._addRpmPackage(pathname)
>   File "/usr/share/current/channel.py", line 850, in _addRpmPackage
>     os.symlink(pathname, linkname)
> OSError: [Errno 17] File exists
> 
> I could not find the second not...tried taking out the first one, same
> error.
> 
> ++
> John Stauffacher
> Network Administrator
> Chapman University
> [email protected]
> 714.628.7249
> 
> "The man who does not read good books has no advantage over the man who
> cannot read them." -Mark Twain  (1835-1910)
> 
> "It is from numberless diverse acts of courage and belief that human
> history is shaped. Each time a man stands up for an ideal, or acts to
> improve the lot of others, or strikes out against injustice, he sends
> forth a tiny ripple of hope, and crossing each other from a million
> different centers of energy and daring those ripples build a current
> which can weep down the mightiest walls of oppression and injustice." -
> Robert F Kennedy
> 
> ============================================
> Pursuant to 47 USC, unsolicited e-mail sent to any of my addresses is
> subject to an archival fee of not less than $500 U.S. per copy. E-mail
> received after any receipt of this notice implies acceptance of these
> terms. A copy of the specific law regarding this activity may be found
> at http://www.law.cornell.edu/uscode/47/227.shtml
> 
> 
> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]] On Behalf Of Hunter
> Matthews
> Sent: Friday, January 17, 2003 1:25 PM
> To: Current Server Mailing List
> Subject: Re: [Current-server] Wierd traceback on update
> 
> Rackem frackem strackem.
> 
> Apply the following patch to the channel.py file.
> 
> patch < name_of_patch
> 
> If it works, please confirm that it does to the list.
> If it doesn't, try taking out the second "not" in the line.
> 
> If a couple people (or john) report sucess with this patch, I'll roll it
> into 1.4.3
> 
> 
> --- channel.py	Fri Jan 17 16:23:08 2003
> +++ channel.py.symlink.patch	Fri Jan 17 16:22:34 2003
> @@ -846,7 +846,7 @@
>          # Add the symlink for the GET requests
>          linkname = misc.PathJoin(self.chanInfo['package_dir'],
>                                   os.path.basename(pathname))
> -        if not os.path.exists(linkname):
> +        if not os.path.exists(linkname) or not
> os.path.islink(linkname):
>              os.symlink(pathname, linkname)
>  
>          # Cache the header itself for getPackageHeader() call
> 
> 
> On Fri, 2003-01-17 at 15:45, John Berninger wrote:
> > OK, I've just found what the problem is.
> > 
> > Hunter, pay attention here, 1.4.x is still your baby.
> > 
> > The line immediately before the symlink command does an os.path.exists
> > sanity check to see if the link exists already or not.  Well, the
> > problem is, the check follows any existing link to see if the target
> > exists; so it sees the symlink, sees the target file doesn't exist,
> and
> > returns 0.  Then the symlink command gets called, but since the
> symlink
> > already exists (pointing nowhere), you get the OSError 17.
> > 
> > I'll try to come up with a sane patch over the weekend and see if I
> > can't get Hunter to make a point release, but we're both extremely
> busy
> > lately, and Current's been kinda relegated to my back burner for the
> > time being...
> > 
> > On Fri, 17 Jan 2003, John Stauffacher wrote:
> > 
> > > I just updated my rpm repository (running current-1.4.2) and I get
> this
> > > traceback:
> > > 
> > > Traceback (innermost last):
> > >   File "/usr/sbin/cadmin", line 325, in ?
> > >     main()
> > >   File "/usr/sbin/cadmin", line 260, in main
> > >     mychan.update()
> > >   File "/usr/share/current/channel.py", line 182, in update
> > >     self._addRpmDir(dir)
> > >   File "/usr/share/current/channel.py", line 624, in _addRpmDir
> > >     self._addRpmPackage(pathname)
> > >   File "/usr/share/current/channel.py", line 850, in _addRpmPackage
> > >     os.symlink(pathname, linkname)
> > > OSError: [Errno 17] File exists
> > > 
> > > I thought I had duplicate files so I re-mirrored updates.redhat.com
> and
> > > I still get the error. Anyone got any ideas?
> > > 
> > > ++
> > > John Stauffacher
> > > Network Administrator
> > > Chapman University
> > > [email protected]
> > > 714.628.7249
> > > 
> > > "The man who does not read good books has no advantage over the man
> who
> > > cannot read them." -Mark Twain  (1835-1910)
> > > 
> > > "It is from numberless diverse acts of courage and belief that human
> > > history is shaped. Each time a man stands up for an ideal, or acts
> to
> > > improve the lot of others, or strikes out against injustice, he
> sends
> > > forth a tiny ripple of hope, and crossing each other from a million
> > > different centers of energy and daring those ripples build a current
> > > which can weep down the mightiest walls of oppression and
> injustice." -
> > > Robert F Kennedy
> > > 
> > > ============================================
> > > Pursuant to 47 USC, unsolicited e-mail sent to any of my addresses
> is
> > > subject to an archival fee of not less than $500 U.S. per copy.
> E-mail
> > > received after any receipt of this notice implies acceptance of
> these
> > > terms. A copy of the specific law regarding this activity may be
> found
> > > at http://www.law.cornell.edu/uscode/47/227.shtml
> > > 
> > > 
> > > _______________________________________________
> > > Current-server mailing list
> > > [email protected]
> > > http://lists.dulug.duke.edu/mailman/listinfo/current-server
> > 
> > -- 
> > Thank you,
> > John Berninger
> > 
> > Systems Administrator		[email protected]
> > Department of Mathematics	Box 8205, Harrelson Hall
> > NC State University		Raleigh, NC 27695
> > Phone:  (919)515-6315		Fax:	(919)515-3798
> > 
> > GPG Key ID: A8C1D45C
> >         Fingerprint: B1BB 90CB 5314 3113 CF22  66AE 822D 42A8 A8C1
> D45C
> > --
> > _______________________________________________
> > Current-server mailing list
> > [email protected]
> > http://lists.dulug.duke.edu/mailman/listinfo/current-server
> > 
> > 
> -- 
> Hunter Matthews                          Unix / Network Administrator
> Office: BioScience 145/244               Duke Univ. Biology Department
> Key: F0F88438 / FFB5 34C0 B350 99A4 BB02  9779 A5DB 8B09 F0F8 8438
> Never take candy from strangers. Especially on the internet.
> 
> _______________________________________________
> Current-server mailing list
> [email protected]
> http://lists.dulug.duke.edu/mailman/listinfo/current-server
> 
> _______________________________________________
> Current-server mailing list
> [email protected]
> http://lists.dulug.duke.edu/mailman/listinfo/current-server

-- 
Thank you,
John Berninger

Systems Administrator		[email protected]
Department of Mathematics	Box 8205, Harrelson Hall
NC State University		Raleigh, NC 27695
Phone:  (919)515-6315		Fax:	(919)515-3798

GPG Key ID: A8C1D45C
        Fingerprint: B1BB 90CB 5314 3113 CF22  66AE 822D 42A8 A8C1 D45C
--